Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gap between nav entry #3235

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add gap between nav entry #3235

merged 1 commit into from
Sep 14, 2022

Conversation

CarlSchwan
Copy link
Contributor

Before:

image

After:

image

@CarlSchwan CarlSchwan added enhancement New feature or request 3. to review Waiting for reviews labels Sep 12, 2022
@CarlSchwan CarlSchwan self-assigned this Sep 12, 2022
@CarlSchwan
Add gap between nav entry
a889d35 
Signed-off-by: Carl Schwan <[email protected]>
marcoambrosini
marcoambrosini approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things make me very happy ❤️

jancborchardt
jancborchardt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great eye for design and details in the mockup @CarlSchwan :)

@raimund-schluessler raimund-schluessler merged commit 108d8e1 into master Sep 14, 2022
@raimund-schluessler raimund-schluessler deleted the add-gap-between-nav-entry branch September 14, 2022 14:03
@raimund-schluessler
Copy link
Contributor

/backport to stable6

@backportbot-nextcloud
Copy link

The backport to stable6 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@CarlSchwan CarlSchwan

Labels
3. to review Waiting for reviews backport-request enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlSchwan @raimund-schluessler @jancborchardt @marcoambrosini