Allow click outside for Popover focus trap #3022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3020 this fixes an issue with the Popver/Actions focus-trap which was added in #2941 and prevented directly opening another Actions menu, when one was already open. Before, you would need two clicks on the second Actions menu trigger to open the other Actions menu, one for closing the first one, one for actually opening the second one.
Try this example code by copying into the docs:
With this PR, each Actions menu opens after one click, no matter if the other is open or not.
There is still an issue open, preventing focusing any other element from within the Actions menu, see #3021.