Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ButtonVue everywhere in the docs #2989

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Use ButtonVue everywhere in the docs #2989

merged 1 commit into from
Aug 10, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Aug 9, 2022 •
edited
Loading

This PR replaces all usages of the normal HTML button with the ButtonVue from nextcloud/vue. Fixes half of #2988.

Before:
Screenshot 2022-08-09 at 21-57-15 Nextcloud Vue Style Guide

After:
Screenshot 2022-08-09 at 22-24-35 Nextcloud Vue Style Guide

@raimund-schluessler
Use ButtonVue everywhere in the docs
f87afc7 
Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: documentation Related to the documentation regression Regression of a previous working feature design Design, UX, interface and interaction design labels Aug 9, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 9, 2022
@raimund-schluessler raimund-schluessler merged commit 9a3e61f into master Aug 10, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/button-in-docs branch August 10, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@GretaD GretaD Awaiting requested review from GretaD

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: documentation Related to the documentation regression Regression of a previous working feature
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@raimund-schluessler @ChristophWurst @JuliaKirschenheuter @Pytal