Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the button into a link when href is provided #2864

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Turn the button into a link when href is provided #2864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e8ec7
Turn the button into a link when href is provided
marcoambrosini Jul 20, 2022
ed8d824
Update src/components/Button/Button.vue
marcoambrosini Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions src/components/Button/Button.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ button {
</docs>

<template>
<button class="button-vue"
v-bind="$attrs"
<root-element class="button-vue"
v-bind="rootElement"
:class="buttonClassObject"
:aria-label="ariaLabel"
:type="nativeType"
Expand All @@ -220,7 +220,7 @@ button {
<slot />
</span>
</span>
</button>
</root-element>
</template>
<script>

Expand Down Expand Up @@ -281,6 +281,15 @@ export default {
type: String,
default: null,
},

/**
* Providing the href attribute turns the button component into a an `a`
* element
*/
href: {
type: String,
default: '',
marcoambrosini marked this conversation as resolved.
Show resolved Hide resolved
},
},

data() {
Expand All @@ -300,6 +309,21 @@ export default {
},

computed: {
// Determines whether the root element is an a or a button
rootElement() {
if (this.href) {
return {
is: 'a',
href: this.href,
...this.$attrs,
}
}
return {
is: 'button',
...this.$attrs,
}
marcoambrosini marked this conversation as resolved.
Show resolved Hide resolved
},

hasText() {
return this.slots?.default !== undefined
&& this.slots?.default[0]?.text
Expand Down