Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the children of AppNavigationItem outside of the main item #2704

Merged
merged 5 commits into from
May 25, 2022
Merged

Put the children of AppNavigationItem outside of the main item #2704

merged 5 commits into from
May 25, 2022

Commits on May 20, 2022

  1. Put the children of AppNavigationItem outide of the main item 

    In the current implementation, a side effect is that it disables the ability to pass
class="active" directly to the AppNavigationItem.

Signed-off-by: Quentin Guidée <[email protected]>

Update src/components/AppNavigationItem/AppNavigationItem.vue

Update src/components/AppNavigationItem/AppNavigationItem.vue
    @quentinguidee @GretaD
    quentinguidee authored and GretaD committed May 20, 2022
    Configuration menu
    Copy the full SHA
    3afa288 View commit details
    Browse the repository at this point in the history

  2. Adjust children style to new component structure 

    Signed-off-by: Raimund Schlüßler <[email protected]>
    @raimund-schluessler
    raimund-schluessler committed May 20, 2022
    Configuration menu
    Copy the full SHA
    767baf5 View commit details
    Browse the repository at this point in the history

  3. Add pinned class to item wrapper 

    Signed-off-by: Raimund Schlüßler <[email protected]>
    @raimund-schluessler
    raimund-schluessler committed May 20, 2022
    Configuration menu
    Copy the full SHA
    c85aa53 View commit details
    Browse the repository at this point in the history

  4. Fix collapsing AppNavigationItem children 

    Signed-off-by: Raimund Schlüßler <[email protected]>
    @raimund-schluessler
    raimund-schluessler committed May 20, 2022
    Configuration menu
    Copy the full SHA
    d70dd19 View commit details
    Browse the repository at this point in the history

  5. Adjust padding right of appnavigation item children 

    Signed-off-by: Raimund Schlüßler <[email protected]>
    @raimund-schluessler
    raimund-schluessler committed May 20, 2022
    Configuration menu
    Copy the full SHA
    eca26a9 View commit details
    Browse the repository at this point in the history