Change Prev/next links to buttons #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanpertsch
added
2. developing
10 tasks
nickvergessen
force-pushed
the
accessibility/modal-navigation-buttons
branch
2 times, most recently
from
8961ef6
to
da9e3de
Compare
Signed-off-by: Vanessa Pertsch <[email protected]>
nickvergessen
force-pushed
the
accessibility/modal-navigation-buttons
branch
from
da9e3de
to
d16c228
Compare
nickvergessen
added
3. to review
Signed-off-by: Joas Schilling <[email protected]>
Pytal
approved these changes
Jul 14, 2022
| {{ t('Close') }} | ||
| </ActionButton> | ||
| </Actions> | ||
| <ButtonVue v-if="canClose && !closeButtonContained" |
There was a problem hiding this comment.
Suggested change
| <ButtonVue v-if="canClose && !closeButtonContained" | |
| <Button v-if="canClose && !closeButtonContained" |
suggestion (non-blocking): Rename ButtonVue to Button where it's used
There was a problem hiding this comment.
It was used like this before. Don't know why.
There was a problem hiding this comment.
When there are regular button elements the names conflict, so we import the vue button as ButtonVue
marcoambrosini
approved these changes
Jul 18, 2022
| {{ t('Close') }} | ||
| </ActionButton> | ||
| </Actions> | ||
| <ButtonVue v-if="canClose && !closeButtonContained" |
There was a problem hiding this comment.
When there are regular button elements the names conflict, so we import the vue button as ButtonVue
Closed
skjnldsv
reviewed
Aug 18, 2022
| @@ -155,14 +155,14 @@ | |||
| </Actions> | |||
|
|
|||
| <!-- Close modal --> | |||
| <Actions v-if="canClose && !closeButtonContained" class="header-close"> | |||
| <ActionButton @click="close"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vanessa Pertsch [email protected]