Fix border radius for small progress bar #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/noid/progress-bar-small
branch
4 times, most recently
from
bc71530
to
2c94f04
Compare
raimund-schluessler
requested review from
quentinguidee,
skjnldsv,
juliusknorr and
ChristophWurst
raimund-schluessler
added
bug
marcoambrosini
approved these changes
Apr 8, 2022
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/progress-bar-small
branch
from
2c94f04
to
9bf1fe5
Compare
skjnldsv
approved these changes
Apr 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
border-radiusof theProgressBarcomponent. I introduced a CSS variable to dynamically set the height. Since the variable is scoped to the respective element, it does not pollute the global scope and multiple progress bars can exist with different heights / border radii on the same page.See this screenshot from the docs in Firefox (I temporarily increased the height with the dev tools to make it obvious):
And in Chrome:
Closes #2569.