Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tertiary buttons hover feedback #2583

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Mar 28, 2022

Add proper hover feedback to tertiary buttons whose icon aren't affected by the color css rule. e.g. emojis

Screen.Recording.2022-03-28.at.17.10.01.mov

Add proper hover feedback to tertiary buttons whose icon
doesn't isn't affected by the color css rule.
e.g. emojis

Signed-off-by: marco <[email protected]>
@marcoambrosini marcoambrosini self-assigned this Mar 28, 2022
@marcoambrosini marcoambrosini added bug Something isn't working 3. to review Waiting for reviews labels Mar 28, 2022
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, didnt test

@marcoambrosini marcoambrosini merged commit 170e2be into master Mar 31, 2022
@marcoambrosini marcoambrosini deleted the bugfix/tertiary-button-hover-feedback branch March 31, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants