-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify linkify usage, move to linkify-string #2275
Conversation
Ref #1678 We have to check if Safari still works with this |
At least for Safari on iOS it still works properly. Also see nextcloud/calendar#3490 where the changes are present already. The previously used linkifyjs/string just moved to its own package linkify-string. So it's the same Code that is used, just without the rest of linkify. This might even reduce the bundle size (need to check). |
680790f
to
8bac58a
Compare
I checked the bundle size, and it stays quite exactly the same. Webpack only bundled I fixed a small issue with linkification in the AppSidebar title, because now the server I think this PR should be good now (maybe just test, that it really works with Safari on the Desktop). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left some minor remarks regarding the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please squash before merging :)
Signed-off-by: Raimund Schlüßler <[email protected]>
76b67cf
to
7f8d45e
Compare
/backport to stable4 |
This unifies the linkify-string usage (we had this function in two places) and switches to the linkify-string package which replaces linkifyjs/string since the latest major release of linkifyjs.
Supersedes #2257.
Closes #1488.