Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use material design icon for AppSidebar star #2265

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Use material design icon for AppSidebar star #2265

merged 2 commits into from
Sep 20, 2021

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Sep 17, 2021 •
edited
Loading

This PR now uses a material design icon for the Appsidebar star. Please check out the updated base images for how it looks now (there is basically no difference, it is only visible in the direct comparision upon close inspection).

Closes #2264.

This PR will need a rebase after #2263, depending on which PR is merged first.

@raimund-schluessler raimund-schluessler added 2. developing Work in progress design Design, UX, interface and interaction design feature: app-sidebar Related to the app-sidebar component backport-request labels Sep 17, 2021
@raimund-schluessler raimund-schluessler added this to the 4.2.0 milestone Sep 17, 2021
@raimund-schluessler raimund-schluessler modified the milestones: 4.2.0, 4.1.2 Sep 17, 2021
@raimund-schluessler raimund-schluessler marked this pull request as ready for review September 18, 2021 11:21
jancborchardt
jancborchardt approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Something for a different PR, but this gets visible in the test images with black primary color (black folder): The star needs a border of color-background to set it apart, just like we do with the status indicator.

@marcoambrosini marcoambrosini merged commit bc0f5d1 into master Sep 20, 2021
@marcoambrosini marcoambrosini deleted the fix/2264/appsidebar-star branch September 20, 2021 11:42
@raimund-schluessler
Copy link
Contributor Author

/backport to stable4

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 20, 2021
Merged
@raimund-schluessler raimund-schluessler modified the milestones: 4.1.2, 4.2.0 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
2. developing Work in progress design Design, UX, interface and interaction design feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

AppSidebar star should use material design icon
4 participants
@raimund-schluessler @jancborchardt @marcoambrosini @szaimen