Fix empty user bubble #2236
Merged
Fix empty user bubble #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/2200/bubble
branch
from
e57781f
to
2486275
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/2200/bubble
branch
from
594ce12
to
5bc2c9d
Compare
raimund-schluessler
requested review from
nickvergessen,
marcoambrosini,
PVince81 and
julien-nc
raimund-schluessler
added
3. to review
|
/backport to stable4 |
marcoambrosini
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200. Supersedes #2234.
The problem was that we use a
divin case the default slot is empty and then<template #trigger>is simply not rendered anymore.I introduced a component which just renders a
divas a wrapper for the #trigger slot in case the default slot is empty.UserBubble without default slot on netlify:
