-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user bubble when username contains a space #1948
Conversation
Signed-off-by: Louis Chemineau <[email protected]>
ad17f93
to
407f7bd
Compare
backport? |
Hello there is this issue(#26861 fixed yet? because am still facing this issue in NC 21.0.4 Version. |
@elhananjair NC 21.0.4 uses |
ow okay I will wait for it, thanks. |
hey @artonge am really sorry to bring this thing again, I was just curious that this issue is not appearing in some nextcloud applications, such as deck, So does this mean some apps in nextcloud uses different versions of vue or built with different mechanism? Thanks |
Yes, not all applications use this Vue component. |
@artonge I don't think the issue has been fixed in NC 23. I am trying here on Talk and Files app and its the same as before |
Can you clear your cache and check again? Can you open another issue if the problem still persist? |
I have installed clean NC 23 and didn't upgrade from previous versions. So I don't think clearing cache or something like that won't help I guess. As you said let me open this issue again. |
The user bubble is broken when there is a space in the username.
This was due to the parsed value being sanitized before applying regexp on it.
I simply changed the regexp to match
"
instead of"
.This should fix: nextcloud/server#26861