Fix counter margin

[marcoambrosini]

fix #1868

Bringing back only the counter fix.

Signed-off-by: Marco Ambrosini [email protected]

[raimund-schluessler]

Actions now miss the right margin:

[marcoambrosini]

Actions now miss the right margin

🤦 done 😅

[raimund-schluessler]

Looks good now.

[raimund-schluessler]

The fix for the Calendar app will still be necessary, but I guess that's inevitable and can be fixed quickly in the Calendar app.

[skjnldsv]

That's a breaker though, not really a fix

[skjnldsv]

If we need to fix something for it to work in another app, that's not ok.
This needs to be backportable to stable3, meaning there should be no other change needed on the app than bumping @nextcloud/vue's version :)

[raimund-schluessler]

If we need to fix something for it to work in another app, that's not ok.
This needs to be backportable to stable3, meaning there should be no other change needed on the app than bumping @nextcloud/vue's version :)

Technically, yes. But using the counter slot like Tasks and Calendar do it, was never really supported by nextcloud/vue. So I am a bit undecided if we need to account for it.

In the Tasks app, I already included the necessary fix:
https://github.com/nextcloud/tasks/blob/master/src/components/AppNavigation/ListItemCalendar.vue#L583-L585

So, I don't mind whatever is decided.

[skjnldsv]

The question is, does it works in any of 3.x.x of nextcloud/vue?
If so I assume following proper semver means we need to have this fixed properly?

[raimund-schluessler]

The question is, does it works in any of 3.x.x of nextcloud/vue?
If so I assume following proper semver means we need to have this fixed properly?

Yes, it does work in 3.x.x. If we want to not break this usage, we could either try to not introduce this wrapper around the CounterBubble or maybe apply this rule to it:

.app-navigation-entry__counter-wrapper {
    margin-right: 2px;
    display: flex;
    align-items: center;
    flex: 0 1 auto;
}

This should also keep it working, I think (didn't test it yet, can do it only in the evening).

[skjnldsv]

Why do we need this wrapper at all btw?
I'm also ok adding the wrapper for 4.x.x but only the margin for 3.x.x @ma12-co :)

[marcoambrosini]

Why do we need this wrapper at all btw?

To apply the extra margin without using v-deep

[marcoambrosini]

Applyed flex rules to solve calendar issue

[marcoambrosini]

/backport to stable3

[raimund-schluessler]

I can confirm it now works without adjustments, nextcloud/tasks#1564.