Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow last crumb to shrink if all crumbs collapsed #1771

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

raimund-schluessler
Copy link
Contributor

This PR allow the last breadcrumb in the breadcrumbs bar to shrink, in case all other breadcrumbs are already hidden. This prevents the breadcrumb from overflowing on narrow screens (e.g. iPhone 8).

Before:
Screenshot_2021-03-20 Inventar - Nextcloud

before

After:
Screenshot_2021-03-20 Inventar - Nextcloud(1)

after

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: breadcrumbs Related to the breadcrumbs components labels Mar 20, 2021
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments :)

@raimund-schluessler
Copy link
Contributor Author

See comments :)

Done.

Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, css

@ChristophWurst ChristophWurst merged commit b376171 into master Mar 22, 2021
@ChristophWurst ChristophWurst deleted the fix/noid/breadcrumb-shrink branch March 22, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: breadcrumbs Related to the breadcrumbs components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants