Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar caching for non-user rendering #1491

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Oct 20, 2020

  • Do not cache if the user is not defined
  • Added debug level
  • Fallback to letters if the url is invalid
<Avatar
	:disable-menu="true"
	:disable-tooltip="true"
	display-name="Hello User"
	:is-no-user="true"
	:size="40"
	url="http://this.is.a.fakeUrl.jpg"
	class="app-content-list-item-icon" />

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Oct 20, 2020
@skjnldsv skjnldsv self-assigned this Oct 20, 2020
@PVince81
Copy link
Contributor

is that for guest users or another scenario ? (steps to reproduce would be nice for verification)

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested, makes sense

@PVince81 PVince81 merged commit 8e4e1f2 into master Oct 20, 2020
@PVince81 PVince81 deleted the fix/avatar-caching branch October 20, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants