Fix ActionInput label height #1361
Conversation
tcitworld
added
bug
| width: #{$clickable-area - $input-margin * 6}; | ||
| height: #{$clickable-area - $input-margin * 6}; |
There was a problem hiding this comment.
But it doesn't make any sense to have 6 here.
The 2 were here to compensate from height/width.
There was a problem hiding this comment.
box-sizing: border-box; might be the better option here.
There was a problem hiding this comment.
Works fine with border-box indeed.
There was a problem hiding this comment.
Iwonder if that wouldn't make sense to apply this to the whole actions component with the * selector. I thought I saw a comment about this somewhere, but can't find it.
If we want to be as independent from server's styling as possible, this might be better 🤔
There was a problem hiding this comment.
Iwonder if that wouldn't make sense to apply this to the whole actions component with the
*selector. I thought I saw a comment about this somewhere, but can't find it.If we want to be as independent from server's styling as possible, this might be better 🤔
I guess this should be ok, since we have this in the server anyway (only for content, but that effects most elements):
#content[class*='app-'] * {
box-sizing:border-box
}
But if we do that, we could as well just do it globally for all vue components.
There was a problem hiding this comment.
But if we do that, we could as well just do it globally for all vue components.
That is what I meant
There was a problem hiding this comment.
But if we do that, we could as well just do it globally for all vue components.
That is what I meant
Ah, ok. I thought you meant to only apply it to the Actions component. If we have it globally, we could also get rid of this https://github.com/nextcloud/nextcloud-vue/blob/master/tests/visual/components/AppSidebar/AppSidebar.visual.js#L40-L49 and this https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/Content/Content.vue#L73-L75, I think.
There was a problem hiding this comment.
Sorry, my message wasn't very clear :p
what do you think @tcitworld ?
Signed-off-by: Julien Veyssier <[email protected]>
tcitworld
force-pushed
the
fix-action-input-label-height
branch
from
8d46fac
to
f9c77d7
Compare
|
Dropped my commit for cleaner history then. :) |
|
@skjnldsv @raimund-schluessler @tcitworld Any objection to merge this? I think it's good to get that even if a more general rule is applied in the future. |
|
Please open a follup issue then :) |
|
Also present in weather widget of 20.0.0 beta 4 |
Noticed in Calendar. See https://nextcloud-vue-components.netlify.app/#/Components/Actions?id=actioninput