-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify a custom action instead of the star #1310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
requested review from
skjnldsv,
georgehrke and
jancborchardt
August 18, 2020 20:57
raimund-schluessler
added
3. to review
Waiting for reviews
feature: app-sidebar
Related to the app-sidebar component
enhancement
New feature or request
labels
Aug 18, 2020
#1288 needs to be merged first. |
raimund-schluessler
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Aug 19, 2020
4 tasks
raimund-schluessler
force-pushed
the
fix/1090/custom-action
branch
from
August 19, 2020 19:01
f1ea31a
to
8c298e8
Compare
Good for review now. |
raimund-schluessler
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Aug 19, 2020
juliusknorr
approved these changes
Aug 19, 2020
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/1090/custom-action
branch
from
August 19, 2020 21:18
8c298e8
to
a3d480d
Compare
skjnldsv
reviewed
Aug 19, 2020
skjnldsv
approved these changes
Aug 19, 2020
Shall we add an example for the docs? |
Fine with me. I will add one. |
raimund-schluessler
force-pushed
the
fix/1090/custom-action
branch
from
August 20, 2020 08:03
c6ed92b
to
9f6c362
Compare
Maybe just add a checkbox? |
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/1090/custom-action
branch
from
August 20, 2020 08:24
9f6c362
to
73b0ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
feature: app-sidebar
Related to the app-sidebar component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to specify a custom action instead of the star icon in the sidebar. Useful e.g. for the Tasks app to toggle the completed state of a task.
Since #1288 introduced quite some changes to the structure, I implemented it on top of #1288. The important commit is f1ea31a. I will rebase this PR here once #1288 is in.