Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a custom action instead of the star #1310

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

raimund-schluessler
Copy link
Contributor

This PR allows to specify a custom action instead of the star icon in the sidebar. Useful e.g. for the Tasks app to toggle the completed state of a task.

Since #1288 introduced quite some changes to the structure, I implemented it on top of #1288. The important commit is f1ea31a. I will rebase this PR here once #1288 is in.

custom-action

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component enhancement New feature or request labels Aug 18, 2020
@raimund-schluessler raimund-schluessler marked this pull request as draft August 19, 2020 07:43
@raimund-schluessler
Copy link
Contributor Author

#1288 needs to be merged first.

@raimund-schluessler raimund-schluessler added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 19, 2020
@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 19, 2020 19:02
@raimund-schluessler
Copy link
Contributor Author

Good for review now.

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 19, 2020
@skjnldsv
Copy link
Contributor

Shall we add an example for the docs?

@raimund-schluessler
Copy link
Contributor Author

Shall we add an example for the docs?

Fine with me. I will add one.

@raimund-schluessler
Copy link
Contributor Author

Shall we add an example for the docs?

I added an avatar as tertiary action example. Probably doesn't really makes sense to have an avatar there (unless the sidebar is about a user), but it shows the use of the tertiary action.

Screenshot_2020-08-20 Nextcloud Vue Style Guide

@skjnldsv
Copy link
Contributor

I added an avatar as tertiary action example. Probably doesn't really makes sense to have an avatar there (unless the sidebar is about a user), but it shows the use of the tertiary action.

Maybe just add a checkbox?

Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler
Copy link
Contributor Author

I added an avatar as tertiary action example. Probably doesn't really makes sense to have an avatar there (unless the sidebar is about a user), but it shows the use of the tertiary action.

Maybe just add a checkbox?

Yes, might be more reasonable. I changed it.

Screenshot_2020-08-20 Nextcloud Vue Style Guide(1)

@raimund-schluessler raimund-schluessler merged commit ff58744 into master Aug 20, 2020
@raimund-schluessler raimund-schluessler deleted the fix/1090/custom-action branch August 20, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants