Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText causes errors on WebKit | Invalid regex #5589

Closed
susnux opened this issue May 13, 2024 · 2 comments · Fixed by #5976
Closed

RichText causes errors on WebKit | Invalid regex #5589

susnux opened this issue May 13, 2024 · 2 comments · Fixed by #5976
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: richtext Related to the richtext component

Comments

@susnux
Copy link
Contributor

susnux commented May 13, 2024

The regex for mentions is using lookbehind which is not supported on all iOS versions / Safari versions we support.
It only works on 16.4+ but we support 15+.

The problem is within the regular expression:

const MENTION_START = /\B(?<![^a-z0-9_\-@.'\s])/.source

@susnux susnux added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: richtext Related to the richtext component labels May 13, 2024
@avatar1024
Copy link

Do we know if this issue is being worked on?

Many thanks

@susnux
Copy link
Contributor Author

susnux commented Jul 16, 2024

It does not look like that. So welcome any contribution :)

arthurlockman added a commit to arthurlockman/nextcloud-vue that referenced this issue Aug 19, 2024
Fixes RichText causes errors on WebKit | Invalid regex nextcloud-libraries#5589

This regex performs the same function as the one used before, but does not make use of negative lookbehinds and therefore should work on older MobileSafari versions.
arthurlockman added a commit to arthurlockman/nextcloud-vue that referenced this issue Aug 19, 2024
Fixes RichText causes errors on WebKit | Invalid regex nextcloud-libraries#5589

This regex performs the same function as the one used before, but does not make use of negative lookbehinds and therefore should work on older MobileSafari versions.

Signed-off-by: Arthur Rosa <[email protected]>
arthurlockman added a commit to arthurlockman/nextcloud-vue that referenced this issue Aug 20, 2024
Fixes RichText causes errors on WebKit | Invalid regex nextcloud-libraries#5589

This regex performs the same function as the one used before, but does not make use of negative lookbehinds and therefore should work on older MobileSafari versions.

Signed-off-by: Arthur Rosa <[email protected]>
susnux pushed a commit to arthurlockman/nextcloud-vue that referenced this issue Aug 20, 2024
…ions

Fixes RichText causes errors on WebKit | Invalid regex nextcloud-libraries#5589

This regex performs the same function as the one used before, but does not make use of negative lookbehinds and therefore should work on older MobileSafari versions.

Co-authored-by: Maksim Sukharev <[email protected]>
Signed-off-by: Arthur Rosa <[email protected]>
backportbot bot pushed a commit that referenced this issue Aug 20, 2024
…ions

Fixes RichText causes errors on WebKit | Invalid regex #5589

This regex performs the same function as the one used before, but does not make use of negative lookbehinds and therefore should work on older MobileSafari versions.

Co-authored-by: Maksim Sukharev <[email protected]>
Signed-off-by: Arthur Rosa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: richtext Related to the richtext component
Projects
None yet
2 participants