Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vue 3 #2154

Closed
18 of 20 tasks
raimund-schluessler opened this issue Aug 2, 2021 · 9 comments · Fixed by #4976
Closed
18 of 20 tasks

Migrate to Vue 3 #2154

raimund-schluessler opened this issue Aug 2, 2021 · 9 comments · Fixed by #4976
Assignees
Labels
2. developing Work in progress dependencies Pull requests that update a dependency file vue 3 Related to the vue 3 migration
Milestone

Comments

@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Aug 2, 2021

This issue exists to track the migration towards Vue 3.

There are multiple things that should be done before any migration can take place. They won't break compatibility with Vue 2, but will help with the later migration towards Vue 3.

Preparations:

Actual migration to Vue 3 #3692:

  • Migrate from floating-vue@1 to floating-vue@2
  • Migrate from @vue/vue2-jest to @vue/vue3-jest
  • Migrate from @cypress/vue@2 to @cypress/vue@3
  • Migrate from splitpanes@2 to splitpanes@3
  • Migrate from vue-multiselect@2 to vue-multiselect@3
  • Migrate from vue-color@2 to @ckpack/vue-color@1
  • More dependency migrations
  • Do the actual migration to Vue 3
  • ...
  • Profit
@raimund-schluessler raimund-schluessler added 1. to develop Accepted and waiting to be taken care of dependencies Pull requests that update a dependency file labels Aug 2, 2021
@juliusknorr
Copy link
Contributor

robcresswell/vue-material-design-icons#230 might be a possible blocker as functional components are used there and are incompatible according to https://v3.vuejs.org/guide/migration/migration-build.html#incompatible

@Pytal
Copy link
Contributor

Pytal commented Aug 20, 2021

Since we're using vue-ripple-directive for the Button component #1808, linking this issue PygmySlowLoris/vue-ripple-directive#32 for future reference 🖖

@robcresswell
Copy link

@juliushaertl Heh, I can see my slowness updating this is causing issues. I have a free weekend, I'll get this fixed. I was quite amazed to see nextcloud using my little plugin, that was nice 😊

@dartcafe
Copy link
Contributor

dartcafe commented Feb 8, 2022

I would like to bumb this issue. At least for the app developers it would be a valuable information, if any roadmap exists or will be released, since the migration of most NC apps will not be done in a sprint. There might some more repos affected, like https://github.com/nextcloud/webpack-vue-config.

The blocker of robcresswell/vue-material-design-icons#230 seems to be removed.

@robcresswell
Copy link

Yes! Sorry, I didn't update here. My lib supports Vue 3 now. Apologies again for holding you up.

@raimund-schluessler raimund-schluessler changed the title Upgrade to Vue 3 Migrate to Vue 3 Apr 3, 2022
@raimund-schluessler
Copy link
Contributor Author

raimund-schluessler commented Apr 3, 2022

I updated the original issue #2154 (comment) to sketch a possible migration path to Vue 3. Feel free to update and adjust.

@raimund-schluessler raimund-schluessler linked a pull request Apr 7, 2022 that will close this issue
@raimund-schluessler raimund-schluessler added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 7, 2022
@raimund-schluessler raimund-schluessler self-assigned this Apr 22, 2022
@raimund-schluessler raimund-schluessler removed a link to a pull request Jan 30, 2023
@raimund-schluessler raimund-schluessler linked a pull request Jan 30, 2023 that will close this issue
2 tasks
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Sep 3, 2023
@raimund-schluessler raimund-schluessler added the vue 3 Related to the vue 3 migration label Sep 8, 2023
@zak39
Copy link

zak39 commented Dec 7, 2023

Hi 👋

I ask for news 🙂
Is the migration to vue3 going well?

@raimund-schluessler
Copy link
Contributor Author

Hi 👋

I ask for news 🙂 Is the migration to vue3 going well?

There is one final PR pending, see #4842. If this is merged we could aim for an alpha release of nextcloud/vue with vue 3 support.

@raimund-schluessler raimund-schluessler linked a pull request Dec 21, 2023 that will close this issue
@raimund-schluessler
Copy link
Contributor Author

The last component was migrated with #4976.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress dependencies Pull requests that update a dependency file vue 3 Related to the vue 3 migration
Projects
None yet
6 participants