Skip to content

Commit

Permalink
chore(vue3): Migrate NcEmptyContent
Browse files Browse the repository at this point in the history
Signed-off-by: Raimund Schlüßler <[email protected]>
  • Loading branch information
raimund-schluessler committed Sep 18, 2023
1 parent 33ecf70 commit 913ecd5
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/components/NcEmptyContent/NcEmptyContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export default {
* Check if a description is given as either property or slot
*/
hasDescription() {
return this.description !== '' || this.$slots.description?.[0]
return this.description !== '' || this.$slots.description?.()?.[0]
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcHeaderMenu/NcHeaderMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export default {
mounted() {
document.addEventListener('keydown', this.onKeyDown)
},
beforeDestroy() {
beforeUnmount() {
document.removeEventListener('keydown', this.onKeyDown)
},
Expand Down
4 changes: 2 additions & 2 deletions src/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ export { default as NcDatetime } from './NcDatetime/index.js'

// Not yet adjusted for vue3
// export { default as NcEmojiPicker } from './NcEmojiPicker/index.js'
// export { default as NcEmptyContent } from './NcEmptyContent/index.js'
export { default as NcEmptyContent } from './NcEmptyContent/index.js'
export { default as NcGuestContent } from './NcGuestContent/index.js'
// export { default as NcHeaderMenu } from './NcHeaderMenu/index.js'
export { default as NcHeaderMenu } from './NcHeaderMenu/index.js'
export { default as NcHighlight } from './NcHighlight/index.js'
export { default as NcIconSvgWrapper } from './NcIconSvgWrapper/index.js'
// Not exported on purpose as it is only meant as a base component
Expand Down
2 changes: 0 additions & 2 deletions styleguide.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ module.exports = async () => {

// Not yet adjusted for vue3
'src/components/NcAvatar*/*.vue',
'src/components/NcEmptyContent*/*.vue',
'src/components/NcHeaderMenu*/*.vue',
'src/components/NcModal*/*.vue',
'src/components/NcRelatedResourcesPanel*/*.vue',
'src/components/NcRichContenteditable*/*.vue',
Expand Down

0 comments on commit 913ecd5

Please sign in to comment.