Skip to content

Commit

Permalink
fix(sidebar): propagate keydown unless mobile
Browse files Browse the repository at this point in the history
Signed-off-by: Varun Patil <[email protected]>
  • Loading branch information
pulsejet committed Apr 4, 2024
1 parent 78d9e5d commit 6b3f513
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/components/NcAppSidebar/NcAppSidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ A working alternative would be using an icon together with an `aria-label`:
ref="sidebar"
class="app-sidebar"
:aria-labelledby="`app-sidebar-vue-${uid}__header`"
@keydown.esc.stop="isMobile && closeSidebar()">
@keydown.esc="onKeydownEsc">
<header :class="{
'app-sidebar-header--with-figure': hasFigure,
'app-sidebar-header--compact': compact,
Expand Down Expand Up @@ -794,6 +794,18 @@ export default {
}
},
/**
* Close the sidebar on pressing the escape key on mobile
*
* @param {KeyboardEvent} event key down event
*/
onKeydownEsc(event) {
if (this.isMobile) {
event.stopPropagation()
this.closeSidebar()
}
},
onBeforeEnter(element) {
/**
* The sidebar is opening and the transition is in progress
Expand Down

0 comments on commit 6b3f513

Please sign in to comment.