Skip to content

Commit

Permalink
fix(NcCheckboxRadioSwitch): Fix invalid indeterminate checkbox semantics
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
Pytal committed Jan 19, 2024
1 parent 6e59fab commit 38f7905
Showing 1 changed file with 4 additions and 13 deletions.
17 changes: 4 additions & 13 deletions src/components/NcCheckboxRadioSwitch/NcCheckboxRadioSwitch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,10 @@ export default {
:disabled="disabled"
:type="inputType"
:value="value"
v-bind="inputProps"
:checked="isChecked"
:indeterminate.prop="indeterminate"
:required="required"
:name="name"
v-on="listeners">
<NcCheckboxContent :id="id"
class="checkbox-radio-switch__content"
Expand Down Expand Up @@ -472,18 +475,6 @@ export default {
return 'span'
},
inputProps() {
if (this.isButtonType) {
return null
}
return {
checked: this.isChecked,
indeterminate: this.indeterminate,
required: this.required,
name: this.name,
}
},
listeners() {
if (this.isButtonType) {
return {
Expand Down

0 comments on commit 38f7905

Please sign in to comment.