Skip to content

Commit

Permalink
Merge pull request #84 from nextcloud-libraries/fix/do-not-set-unexpe…
Browse files Browse the repository at this point in the history
…cted-config

fix: Do not set vue's `comments` setting for dev builds
  • Loading branch information
susnux authored Dec 18, 2023
2 parents 026b470 + 2b72ba6 commit dabcb85
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions lib/baseConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import type { CoreJSPluginOptions } from 'rollup-plugin-corejs'
import type { UserConfigExport, UserConfigFn, Rollup } from 'vite'

import { readFileSync } from 'node:fs'
import { type CoreJSPluginOptions, corejsPlugin } from 'rollup-plugin-corejs'
import { corejsPlugin } from 'rollup-plugin-corejs'
import { minify as minifyPlugin } from 'rollup-plugin-esbuild-minify/lib/index.js'
import { nodePolyfills } from 'vite-plugin-node-polyfills'
import { defineConfig, mergeConfig, type UserConfigExport, type UserConfigFn, type Rollup } from 'vite'
import { defineConfig, mergeConfig } from 'vite'
import { RemoveEnsureWatchPlugin } from './plugins/RemoveEnsureWatch.js'

import replace from '@rollup/plugin-replace'
Expand Down Expand Up @@ -127,11 +130,6 @@ export function createBaseConfig(options: BaseOptions = {}): UserConfigFn {
style: {
trim: true,
},
template: {
compilerOptions: {
comments: isDev,
},
},
}),
// Add custom plugins
...plugins,
Expand Down

0 comments on commit dabcb85

Please sign in to comment.