fix(uploader): Make sure every request is added to the job queue #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 16.4kB ⬆️
|
skjnldsv
approved these changes
Aug 13, 2024
Remove the hack with the concurrency of the job queue, instead refactor the directory creation: 1. Add it to the upload queue (to track progress) 2. Add the request to the job queue 3. Wait for parent to be created -> continue with children Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/batch-upload
branch
from
2bb3760
to
e4b9d1c
Compare
Merged
|
I'm 99% sure this broke the conflict upload. Investigating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the hack with the concurrency of the job queue, instead refactor the directory creation:
Screen shots
Note that for demonstration purpose I limited the concurrency to 3 and throttled the network.
Bildschirmaufnahme_20240813_165415.webm
Sorry for the big diff, but some refactoring needed to get rid of some of my hacks 😅