Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Move package to vite for bundling + compress translations #781

Merged
merged 1 commit into from
Jan 10, 2024
Merged

enh: Move package to vite for bundling + compress translations #781

merged 1 commit into from
Jan 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 9, 2024

This includes a lot of changes:

  1. Move to vite for bundling (reduces configurations and dependencies)
  2. Compress translations by removing unneeded information, this reduces bundle size of using application by ~10kb
  3. Explicitly import moment with locales, otherwise the locales are not included in bundles when using tree shaking like vite (fixes Submission date not in locale format nextcloud/forms#1856 and fixes Datestrings from moment not correctly localized nextcloud/tasks#2448)

@susnux susnux force-pushed the enh/improve-package branch 6 times, most recently from a967ad2 to d0a6ca7 Compare January 9, 2024 23:23
@susnux susnux force-pushed the enh/improve-package branch from d0a6ca7 to 83f4a1b Compare January 9, 2024 23:32
This was referenced Jan 9, 2024
Closed
Closed
Closed
raimund-schluessler
raimund-schluessler approved these changes Jan 10, 2024
View reviewed changes
Copy link

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well with the Tasks app 👍

@raimund-schluessler
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

@Chartman123
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

I'd expect to have a solution for #407 in a 2.0.0...

@raimund-schluessler
Copy link

I suppose this will be 2.0.0 of nextcloud/moment?

I'd expect to have a solution for #407 in a 2.0.0...

Well, I would not delay the next major release because of #407, because that will likely be a new package completely.

@susnux susnux merged commit dfb497c into master Jan 10, 2024
12 checks passed
@susnux susnux deleted the enh/improve-package branch January 10, 2024 10:40
@susnux susnux mentioned this pull request Jan 10, 2024
Merged
@ShGKme ShGKme mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@st3iny st3iny Awaiting requested review from st3iny

@korelstar korelstar Awaiting requested review from korelstar

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datestrings from moment not correctly localized Submission date not in locale format
3 participants
@susnux @raimund-schluessler @Chartman123