Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create node-when-unrelated.yml #646

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Create node-when-unrelated.yml #646

merged 1 commit into from
Jun 25, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jun 25, 2023

Not needed for 2.2.0

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv requested a review from susnux June 25, 2023 13:40
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (03070c9) 84.57% compared to head (ff44512) 84.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files           6        6           
  Lines         188      188           
  Branches       67       67           
=======================================
  Hits          159      159           
  Misses         28       28           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

susnux

This comment was marked as outdated.

@susnux susnux self-requested a review June 25, 2023 13:43
@susnux susnux dismissed their stale review June 25, 2023 13:43

missing

pull_request:
paths-ignore:
- '.github/workflows/**'
- 'src/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be lib/**?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from the template 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't fully apply to some npm packages 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So written for apps not libs, but I think it should work by the last few rules so

@skjnldsv skjnldsv enabled auto-merge June 25, 2023 14:06
@skjnldsv skjnldsv merged commit 7360cce into master Jun 25, 2023
@skjnldsv skjnldsv deleted the skjnldsv-patch-1 branch June 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants