-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create node-when-unrelated.yml #646
Conversation
Signed-off-by: John Molakvoæ <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 6 6
Lines 188 188
Branches 67 67
=======================================
Hits 159 159
Misses 28 28
Partials 1 1 ☔ View full report in Codecov by Sentry. |
pull_request: | ||
paths-ignore: | ||
- '.github/workflows/**' | ||
- 'src/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it not be lib/**
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from the template 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it doesn't fully apply to some npm packages 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So written for apps not libs, but I think it should work by the last few rules so
Not needed for 2.2.0