Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package exports #543

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Fix package exports #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f0d34
fix: Rewrite package exports to allow typescript projects with node16…
susnux Jun 14, 2023
ea0e8be
chore: Restructure
susnux Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,30 @@
"name": "@nextcloud/initial-state",
"version": "2.0.0",
"description": "Access data from the nextcloud server-side initial state API within apps.",
"homepage": "https://github.com/nextcloud/nextcloud-initial-state#readme",
"author": "Christoph Wurst",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can undo this, it just "hurt my eye" that the package.json was like meta data -> scripts -> metadata -> dependencies 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actively maintaining this package so I think it would not make a lot of sense to list me as the author

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did just move it, not added it 😉
You already were mentioned as author.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh

"license": "GPL-3.0-or-later",
"repository": {
"type": "git",
"url": "https://github.com/nextcloud/nextcloud-initial-state"
},
"keywords": [
"nextcloud"
],
"files": [
"dist/",
"CHANGELOG.md"
],
"type": "module",
"main": "dist/index.cjs",
"types": "dist/index.d.ts",
"exports": {
"import": "./dist/index.es.mjs",
"require": "./dist/index.cjs",
"types": "./dist/index.d.ts"
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.es.mjs",
"require": "./dist/index.cjs"
}
},
"files": [
"dist/"
],
"scripts": {
"build": "rollup --config rollup.config.js",
"build:doc": "typedoc --out dist/doc lib/index.ts && touch dist/doc/.nojekyll",
Expand All @@ -21,16 +34,6 @@
"test": "jest",
"test:watch": "jest --watchAll"
},
"keywords": [
"nextcloud"
],
"homepage": "https://github.com/nextcloud/nextcloud-initial-state#readme",
"author": "Christoph Wurst",
"license": "GPL-3.0-or-later",
"repository": {
"type": "git",
"url": "https://github.com/nextcloud/nextcloud-initial-state"
},
"devDependencies": {
"@rollup/plugin-typescript": "^11.1.1",
"jest": "^29.5.0",
Expand Down