Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilePicker: Navigation and filter should be on separate rows on mobile #882

Merged
merged 2 commits into from
Aug 10, 2023
Merged

FilePicker: Navigation and filter should be on separate rows on mobile #882

merged 2 commits into from
Aug 10, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 10, 2023

Fixing the design review comment by @szaimen

Screenshots

before after
image image

szaimen
szaimen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the screenshot but didnt review the code

@AndyScherzinger AndyScherzinger added this to the 4.2.0 milestone Aug 10, 2023
@susnux susnux merged commit 6b44dce into master Aug 10, 2023
6 checks passed
@susnux susnux deleted the fix/mobile-filepicker branch August 10, 2023 17:03
@susnux susnux mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @AndyScherzinger @szaimen