Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update typescript deps and co #569

Merged
merged 4 commits into from
Jun 27, 2023
Merged

chore: update typescript deps and co #569

merged 4 commits into from
Jun 27, 2023

Conversation

skjnldsv
Copy link
Contributor 

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^16.0.0" from @nextcloud/[email protected]
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.3.0-beta.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^15.0.0" from [email protected]
npm ERR! node_modules/eslint-config-standard
npm ERR!   peer eslint-config-standard@"^17.0.0" from @nextcloud/[email protected]
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.3.0-beta.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.0.0" from [email protected]
npm ERR!   node_modules/eslint-config-standard
npm ERR!     peer eslint-config-standard@"^17.0.0" from @nextcloud/[email protected]
npm ERR!     node_modules/@nextcloud/eslint-config
npm ERR!       dev @nextcloud/eslint-config@"^8.3.0-beta.1" from the root project

@skjnldsv skjnldsv added bug Something isn't working dependencies Pull requests that update a dependency file 3. to review labels Jun 27, 2023
@skjnldsv skjnldsv requested a review from susnux June 27, 2023 08:59
@skjnldsv skjnldsv self-assigned this Jun 27, 2023
susnux
susnux reviewed Jun 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@skjnldsv
8.3.0-beta.2
d718ee6 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv
Copy link
Contributor Author

Done!

@skjnldsv skjnldsv requested a review from susnux June 27, 2023 09:15
@susnux
Copy link
Contributor

susnux commented Jun 27, 2023

While you are at it maybe run npm audit fix at least for me there are 30 issues before and only 27 after 🙈

@skjnldsv
chore: audit fix
e6ada8a 
Signed-off-by: John Molakvoæ <[email protected]>
susnux
susnux approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@skjnldsv skjnldsv merged commit 84b5b8e into master Jun 27, 2023
@skjnldsv skjnldsv deleted the dependaskjnldsv/bumps branch June 27, 2023 09:45
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @susnux