Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat example and unit tests #16

Merged
merged 20 commits into from
Oct 21, 2020
Merged

Chat example and unit tests #16

merged 20 commits into from
Oct 21, 2020

Conversation

erny
Copy link
Member

@erny erny commented Oct 20, 2020

Basic unit test for python-socketio chat.

@erny erny requested a review from ernyrev October 20, 2020 17:08
@erny erny self-assigned this Oct 20, 2020
ernyrev
ernyrev approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@ernyrev ernyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erny erny merged commit c76d789 into main Oct 21, 2020
@erny erny deleted the feat/basic-chat branch October 21, 2020 01:04
@erny erny changed the title Unit tests Chat example and unit tests Oct 21, 2020
@erny erny mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernyrev ernyrev ernyrev approved these changes

Assignees

@erny erny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erny @ernyrev