Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node 18 #5656

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Add support for Node 18 #5656

merged 3 commits into from
Oct 31, 2022

Conversation

ncmbch
Copy link
Contributor

@ncmbch ncmbch commented Oct 27, 2022

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Add Support fo the current LTS Version of Node (v18)

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: Node.js 18 Support

📌 Resources

@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Oct 29, 2022 at 0:45AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 27, 2022 10:30 Inactive
@rdgr
Copy link

rdgr commented Oct 28, 2022

Happy to see a PR to add Node 18 support! :)

@trevoro
Copy link

trevoro commented Oct 28, 2022

Anything I can do to help this one along?

@vercel vercel bot temporarily deployed to Preview October 29, 2022 08:45 Inactive
ThangHuuVu
ThangHuuVu requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ncmbch 🙌
Please update the node engine in packages/next-auth/package.json too

ThangHuuVu
ThangHuuVu approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ThangHuuVu
Copy link
Member

ThangHuuVu commented Oct 30, 2022 •
edited
Loading

On second thought, it may be better to follow openid-client's supported engine strategy (remove engines version restriction), since this is our main Node.js dependency.
See: panva/openid-client@9aefba3
cc @balazsorban44

@balazsorban44
Copy link
Member

We can land this now, upcoming changes will make the engines option obsolete.

@balazsorban44 balazsorban44 merged commit 30ad639 into nextauthjs:main Oct 31, 2022
@rafaelderolez rafaelderolez mentioned this pull request Dec 21, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

@0ubbe 0ubbe Awaiting requested review from 0ubbe

@ndom91 ndom91 Awaiting requested review from ndom91 ndom91 is a code owner

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44 balazsorban44 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js 18 Support
5 participants
@ncmbch @rdgr @trevoro @ThangHuuVu @balazsorban44