Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check url starts with http #3077

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

srijans38
Copy link
Contributor

Reasoning 💡

If the url does not start with 'http', prefix it with 'https://' to be in compliance with the URL API

Affected issues 🎟

Fixes #3074

@github-actions github-actions bot added the core Refers to `@auth/core` label Oct 31, 2021
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it locally, and it works nicely. Thanks, and a good catch!

@balazsorban44 balazsorban44 merged commit b66afcc into nextauthjs:beta Oct 31, 2021
@BulatDashiev
Copy link

@balazsorban44 can you please tell me how to install next-auth@beta with this merge request?

@balazsorban44
Copy link
Member

You cannot, it's not part of any release yet. No ETA, but soon.

@BulatDashiev
Copy link

I can't deploy my preview build on Vercel without this, when it would be released?

@srijans38
Copy link
Contributor Author

srijans38 commented Nov 11, 2021

@BulatDashiev to get this working temporarily, you can set the NEXTAUTH_URL env var in vercel settings to the pattern that is used by vercel for git branches. I believe the pattern is (project-name)-git-(git-branch)-(account/team-name).vercel.app . For example - testapp-git-develop-srijans38.vercel.app . This should (hopefully) fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants