-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(adapters): cleanup sqlite3
+ better-sqlite3
for libsql
#10813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndom91
requested review from
ubbe-xyz,
ThangHuuVu and
balazsorban44
as code owners
May 4, 2024 12:05
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
github-actions
bot
added
adapters
Changes related to the core code concerning database adapters
typeorm
@auth/typeorm-adapter
labels
May 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10813 +/- ##
=======================================
Coverage 37.48% 37.48%
=======================================
Files 173 173
Lines 27026 27026
Branches 1174 1174
=======================================
Hits 10131 10131
Misses 16895 16895 ☔ View full report in Codecov by Sentry. |
Broken Link Checker
|
ndom91
changed the title
chore: cleanup sqlite3 for better-sqlite3
chore(adapters): cleanup sqlite3 for better-sqlite3
May 9, 2024
ndom91
changed the title
chore(adapters): cleanup sqlite3 for better-sqlite3
chore(adapters): cleanup May 9, 2024
sqlite3
+ better-sqlite3
for libsql
hillac
pushed a commit
to hillac/next-auth
that referenced
this pull request
Jun 19, 2024
k3k8
pushed a commit
to k3k8/next-auth
that referenced
this pull request
Aug 1, 2024
JipSterk
pushed a commit
to JipSterk/next-auth
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
sqlite3
andbetter-sqlite3
forlibsql
, which is a JS-basedbetter-sqlite3
-API compatible sqlite client from the Turso folks, i.e. we don't neednode-gyp
and it can run on the edge.devDependencies
, so its not breaking anything in the shipped pkgs. All tests still pass 🙏Notes
libsql
(yet) due to D1 using thebind
fn frombetter-sqlite3
, whichlibsql
hasn't implemented🧢 Checklist
🎫 Affected issues
📌 Resources