Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support dark mode for note tags in modern style #828

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

sghuang19
Copy link
Member

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

No dark color maps are specified for notes in modern style, which looks bad. See #513

What is the new behavior?

image
  • $notes-modern-{bg,text,border,hover}-dark are added
  • I simply exchanged bg with text, hover with border, and did some adjustments in lightness and saturation. Which is not perfect but acceptable in my opinion. Plus the code looks kinda elegant?

How to use?

In NexT _config.yml:

note:
  style: modern

Copy link

welcome bot commented Aug 15, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10398540209

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.446%

Totals Coverage Status
Change from base Build 9517060757: 0.0%
Covered Lines: 400
Relevant Lines: 405

💛 - Coveralls

@stevenjoezhang
Copy link
Member

Thank you for your contribution. The previous color choices for the dark mode theme were not very good (I am not a professional designer), and the color scheme you revised is very nice. I will further test and merge the pull request.

@sghuang19 sghuang19 linked an issue Aug 15, 2024 that may be closed by this pull request
@stevenjoezhang stevenjoezhang added this to the 8.20.1 milestone Sep 3, 2024
@stevenjoezhang stevenjoezhang merged commit 1b85220 into next-theme:master Sep 20, 2024
12 checks passed
Copy link

welcome bot commented Sep 20, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

note tag style:modern 暗黑模式不工作
4 participants