-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: display sidebar on mobile for Pisces and Gemini, fix issue #708 #710
Conversation
Thanks so much for opening your first PR here! |
Pull Request Test Coverage Report for Build 8849477699Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thanks for your contribution! I'm quite busy right now, I'll review & merge it later! 🚀 |
Thank you for your patience. I will conduct the test & merge as soon as possible! This feature is very nice and important to the theme~ |
My pleasure! |
This pull request contains changes to the configuration file. Please make sure the documentation in NexT website is changed or added. |
I have made some changes, and I think it is now ready to be merged. If there are any issues, please let me know. |
Congrats on merging your first pull request here! 🎉 How awesome! |
PR Checklist
PR Type
What is the current behavior?
Sidebar does not display on tablet or mobile for scheme Pisces and Gemini.
Issue resolved: #708
What is the new behavior?
new option on_mobile: Only for Pisces and Gemini. If enabled, a sidebar toggle button will appear on mobile website, just like the way that scheme Muse&Mist work.
new option button_reverse: For all schemes. If enabled, the position of back2top button and sidebar toggle button will be reversed (left to right, right to left).
How to use?
In NexT
_config.yml
: