Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not updated Internal version #70

Closed
wants to merge 2 commits into from
Closed

fix not updated Internal version #70

wants to merge 2 commits into from

Conversation

ljcbaby
Copy link
Member

@ljcbaby ljcbaby commented Aug 1, 2020

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features). Not needed
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved: Updated the annotated Internal version which not updated in version 1f26b10

What is the new behavior?

  • Link to demo site with this changes: null
  • Screenshots with this changes: null

How to use?

In NexT _config.yml: null

Update the Internal version which not updated in version 1f26b10
@welcome
Copy link

welcome bot commented Aug 1, 2020

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2020

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang
Copy link
Member

Thanks for your contribution. However, Internal version means the version of files in this folder: https://github.com/next-theme/hexo-theme-next/tree/master/source/lib and it's not necessary to update the version.

See also #61 (comment)
https://theme-next.js.org/docs/advanced-settings#Core-Plugins

@ljcbaby
Copy link
Member Author

ljcbaby commented Aug 1, 2020

So I should update the Internal files too?

@ljcbaby
Copy link
Member Author

ljcbaby commented Aug 1, 2020

Thanks for your contribution. However, Internal version means the version of files in this folder: https://github.com/next-theme/hexo-theme-next/tree/master/source/lib and it's not necessary to update the version.

See also #61 (comment)
https://theme-next.js.org/docs/advanced-settings#Core-Plugins

For inconsistent versions, I have some obsessive-compulsive disorder

@stevenjoezhang
Copy link
Member

Thanks very much! In fact I have some obsessive-compulsive disorder too 😂
It's time to make a choice:

  1. Inconsistent versions
  2. When a new version of any dependency packages is released, update these compressed / binary files, which is not very elegant in the Git commit history

Give me some time, I will think about whether there is a third way. There have been many discussions about how to manage NexT's dependency packages, e.g. using submodule or npm: theme-next/hexo-theme-next#663
The problem is that most users use git clone to install a Hexo theme, not npm install, so users need to execute additional commands after the theme installation.

@stevenjoezhang
Copy link
Member

Superseded by #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants