Step1 #425
Merged
Step1 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksy90101
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
리뷰요청드립니다.
조금 감이 안와서 우선 서비스의 로직을 도메인 객체에 넣는것만 진행했습니다.
힌트를 보니 3개 이상의 인스턴스 변수를 가진 클래스를 사용하지 말라고 되어있는데 어떤 방향으로 진행해야할지 조금 난해한거같습니다.
title, contents 등을 포장한 클래스를 만들라는 의미인건가요? 아니면 NsUser나 Answer 클래스를 Question과 분리하라는 의도인건가요?