1단계 - 레거시 코드 리팩터링 #391
Open
1단계 - 레거시 코드 리팩터링 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyucumber
requested changes
Dec 15, 2023
| return answers; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Question [id=" + getId() + ", title=" + title + ", contents=" + contents + ", writer=" + writer + "]"; | ||
| } | ||
|
|
||
| public void delete(NsUser loginUser) throws CannotDeleteException { | ||
| if (!isOwner(loginUser)) { |
There was a problem hiding this comment.
isOwner의 내부를 보면 아래와 같은 메서드를 호출하고 있습니다.
writer.equals(loginUser);equals가 적절히 구현되어있는지도 한번 확인해보시면 좋을 것 같네요!
Comment on lines
+20
to
+26
| public void delete(NsUser loginUser) throws CannotDeleteException { | ||
| for(Answer answer : answers) { | ||
| answer.delete(loginUser); | ||
| } | ||
| } | ||
|
|
||
| public List<DeleteHistory> deleteHistories() { |
There was a problem hiding this comment.
answer.deleteHistory 내부에서 LocalDateTime.now()를 사용하고 있는 것 같아요.
delete 시점과 deleteHistories가 호출된 시점이 약간 차이가 있을 수 있지 않을까요?
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class Answers { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 리뷰어님😊
코드리뷰 부탁드리겠습니다.
강의를 들은 후에 리팩토링을 진행하였더니 강의에서 들은 내용으로 리팩토링을 하게 되네요😅
감사합니다.