π 2λ¨κ³ - μκ°μ μ²(λλ©μΈ λͺ¨λΈ) #326
Conversation
β¦ate μ κ·Ό μ νμ μ€μ , `deleteQuestionAndRelatedAnswer` μμ±
| @@ -0,0 +1,5 @@ | |||
| package nextstep.courses.domain; | |||
|
|
|||
| public enum ImageExtension { | |||
There was a problem hiding this comment.
νμ₯μλ enumλ³΄λ€ μ κ·μμΌλ‘ κ²μ¬ν΄λ³΄λκ² μ΄λ¨κΉμ ?
| } | ||
| } | ||
|
|
||
| public PaidSessionType registered(long payedPrice, int headCount) { |
There was a problem hiding this comment.
λ±λ‘ κ°λ₯νμ§ νμΈνλ λΆλΆμ μΆμννλ©΄ μ’μ κ² κ°μμ! μ§κΈμ μΈν°νμ΄μ€μ λ©μλκ° νλλ μλ κ² κ°μμμ..!
λμκ°μ κ·Έλ° λλμ΄ λλ€λ©΄ sessionTypeμ EnumμΌλ‘ κ΄λ¦¬ν΄λ μ’μ§ μμκΉμ ?
μ§κΈμ SessionTypeμ DBλ‘ κ΄λ¦¬νλ €λ©΄ μλ λ³λμ λλ©μΈμ΄ λμ΄μΌ ν κ² κ°μμ!
| @@ -0,0 +1,13 @@ | |||
| package nextstep.courses.domain; | |||
|
|
|||
| public class Session { | |||
There was a problem hiding this comment.
μμ±μλ λ©μλκ° λ€ μκ΅°μ..!
μκ° μ μ²μ λν μ±
μμ Sessionμ΄ κ°μ§κ³ μμ΄μΌ νμ§ μμκΉμ ?
There was a problem hiding this comment.
λ무 λ§λ§νμ΅λλ€.. π’
- serviceμ λ§ κ΅¬νλ§ ν΄λ³΄κ³ μ΄μ²λΌ λλ©μΈμ μ± μμ λκΈ°λ €λ κ°μ΄ μ μ€μ§ μμμ΅λλ€.
- λλ©μΈμ μ± μμ λν κ°μ΄ μμ€λ λ―Έμ μ μ΄ν΄νκΈ° νλ€μμ΅λλ€.
μ ν λκ»μλ κ·ΈλΆλΆμ λλΌμ
¨λμ§ λ°λ»νκ² νΌλλ°± ν΄μ£Όμ
μ μ‘°κΈ κΈ°μ΄μ μ°¨λ¦° κ² κ°μ΅λλ€.
μ μ μ°¨λ¦¬κ³ λ€μ ν΄μ pr μ¬λ¦¬κ² μ΅λλ€. πππππ
|
|
||
| public class SessionImage { | ||
|
|
||
| private static final int ONE_MEGA_BYTE = 1_000_000; |
There was a problem hiding this comment.
νμΌ ν¬κΈ°λ λ³΄ν΅ byte λ¨μλ‘, 1024*1024 μλ° μμΌλ‘ ννν΄μ ~
| validation(width, height); | ||
| this.width = width; | ||
| this.height = height; | ||
| this.ratio = calculateRatio(); |
There was a problem hiding this comment.
μ ? μ΄κ±Έ μ κ°μ§κ³ μλκ±°μ£ ?
| } | ||
|
|
||
| private void ratioValidate(int width, int height) { | ||
| if (WIDTH_RATIO != calculaateWidthRatio(width) && HEIGHT_RATIO != calculaateHeightRatio(height)) { |
There was a problem hiding this comment.
μλ width * HEIGHT_RATIO != height * WIDTH_RATIO μλ κ² ννν μ μμ κ² κ°μμ!
μλ νμΈμ! μ ν λ π
μ΄μ μ½λ리뷰μ μ κ° μ§λ¬Έμ λͺκ° νλλ°.. λ¨Έμ§λ μνλΌμ μ ν λκ»μ νμΈ λͺ»ν΄μ£Όμ€κΉλ΄ μλμ λ§ν¬λ₯Ό λ΅λλ€!
λ²κ±°λ‘μ§λ§ νμΈ ν λ΅λ³ λΆνλλ¦¬κ² μ΅λλ€. π
μ΄μ μ½λ리뷰
μ΄λ² ꡬνμ νλ©΄μ λλ체 λ ꡬνν΄μΌνλκ±°μ§? π€ λΌλ μκ°μ΄ μκΎΈ λ€λλΌκ΅¬μ.
λλ©μΈλ§ ꡬννλ©΄ λλ 건μ§.. μλΉμ€λ ꡬνμ ν΄μΌνλ건μ§..
μμν ν¨ν΄μ κ³Όμ κ³ μν¬λ₯Έ μ½λμ§λ§ μ ν λμ λμμ λ°κ³ μ μ¬λ €λ΄ λλ€.
μλΆνλ립λλ€! πππππ