Step2 #1830
Open
Step2 #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sah3122
requested changes
May 26, 2023
| @@ -0,0 +1,65 @@ | |||
| package nextstep.ladder; | |||
| } | ||
|
|
||
| private void placeLegWithStrategy(GenerationStrategy strategy, Position position) { | ||
| if (isLegPlaceableOnPosition(position) && strategy.shouldPlace()) { |
There was a problem hiding this comment.
strategy는 매번 random boolean 값을 리턴하고, 현재 위치 기준으로 왼쪽 사다리 연결 선이 존재하는지 검증 👍
| import java.util.stream.LongStream; | ||
|
|
||
| public class Legs { | ||
| private final Set<Position> legLeftPositions; |
There was a problem hiding this comment.
Legs일급 컬렉션이 사다리 연결선의 정보를 가지는 Position을 가지는것 보다 Leg라는 클래스를 도출하여 사다리 가로 한줄과 연결선에 대한 정보를 가지는 Position의 구현은 어떻게 생각하시나요 ?
Leg 객체에 사다리를 그릴수 있는지에 대한 메시지를 던져보는 구현도 좋은 구현이 될수 있을것 같습니다 😄
| @@ -0,0 +1,20 @@ | |||
| package nextstep.ladder; | |||
|
|
|||
| public class NaturalInput { | |||
There was a problem hiding this comment.
NaturalInput을 활용하여 Natural객체를 생성하는것보단 Natural에 다양한 생성자를 정의해보는건 어떨까요 ?
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class UsersInput { |
| import java.util.Iterator; | ||
| import java.util.List; | ||
|
|
||
| public class Users implements Iterable<String> { |
There was a problem hiding this comment.
사다리 게임에 참여하는 유저가 1명 이하인경우 정상적인 게임이 동작할수 있을까요 ?
| import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat; | ||
|
|
||
| public class LadderTest { | ||
| @Test |
There was a problem hiding this comment.
@DisplayName 을 활용하여 테스트의 의도를 명확하게 나타내보는건 어떠세요 ?
|
|
||
| import java.util.Scanner; | ||
|
|
||
| public class LadderView { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 부탁드립니다.