Step3리뷰 요청드립니다. #501
Open
Step3리뷰 요청드립니다. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/nextstep/subway/acceptance/AcceptanceTest.java # src/test/java/nextstep/subway/acceptance/StationAcceptanceTest.java
시작, 종점 역 마킹 제거
HyunSung-Na
requested changes
Aug 4, 2022
src/main/java/nextstep/subway/applicaion/section/SectionService.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Service | ||
| @Transactional(readOnly = true) | ||
| public class SectionService { |
There was a problem hiding this comment.
해당 Section 은 Line 에 속해 있는 도메인으로 보이는데요
SectionService 를 선언하지 않아도 해당 로직을 Sections 와 Line 에서 할 수 있을 것으로 보이는데 어떻게 생각하시나요? 😊
There was a problem hiding this comment.
클린아키텍쳐에서처럼 서비스가 비대해지는 것을 방지하기 위해 한 컨트롤러마다 GetSectionUseCase 와 같이 나누는 것까지는 아니더라도 최소한 중심이 되는 도메인(Section)별로 나누는 것이 좋다고 생각했습니다
응집시켜두는 것이 좋다고 생각하시는 이유가 있으실까요?
src/test/java/nextstep/subway/acceptance/LineAcceptanceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/nextstep/subway/acceptance/SectionAcceptanceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/nextstep/subway/applicaion/line/domain/Sections.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
현재 step2가 머지되지 않아 step2가 머지되면 좀더 깔끔하게 Pr 정리하겠습니다.
늦었지만 확인해주시면 감사하겠습니다 🙏