add unit tests and fix some trivial issues #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection is not used at all, let's reduce the dependency.
This attribute was replaced by private _mh_utility_used and there should be no reason to make this attribute public. Once any method or @Property is accessed it is already set to True so it does not have any information for the outside caller.
is_connected is actually an integer so we need to convert it
|
@justin-stephenson May I ask you for a review? I don't think it is necessary to deep dive into every single test case. |
pbrezina
force-pushed
the
tests
branch
2 times, most recently
from
f798880
to
671678d
Compare
Sure, how do I run the tests locally? |
Either run pytest directly or via tox. |
justin-stephenson
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started writing extensive unit tests, this is the first batch. I found some very minor issues that are fixed here as well.