marks: put generic error message in correct scope

next-actions · Jan 31, 2024 · a089db0 · a089db0
1 parent 7317290
commit a089db0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pytest_mh/_private/marks.py b/pytest_mh/_private/marks.py
@@ -151,9 +151,10 @@ def Create(cls, item: pytest.Function, mark: pytest.Mark) -> TopologyMark:
         :raises ValueError:
         :rtype: TopologyMark
         """
+        nodeid = item.parent.nodeid if item.parent is not None else ""
+        error = f"{nodeid}::{item.originalname}: invalid arguments for @pytest.mark.topology"
+
         if not mark.args or len(mark.args) > 3:
-            nodeid = item.parent.nodeid if item.parent is not None else ""
-            error = f"{nodeid}::{item.originalname}: invalid arguments for @pytest.mark.topology"
             raise ValueError(error)
 
         # Constructor for KnownTopologyBase