Add "Hourly" as a default interval #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A message like "Based on your store's configuration, new orders have been put on hold until April 27, 2020" isn't very useful if it's already 2020-04-27 but orders are just turned off until the top of the next hour. The new rules for the admin messaging are: 1. If the next interval starts sometime today, show the [local] time it will begin (hourly) 2. If it restarts at midnight, explicitly say "midnight" (hourly, daily) 3. Otherwise, show the date (weekly, monthly)
…_should_not_limit_results() test
stevegrunwell
changed the title
|
Just realized the README hasn't been updated with the new placeholders, adding now. |
bswatson
approved these changes
Apr 27, 2020
|
Waiting to merge until the readme is updated |
bswatson
approved these changes
Apr 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for "hourly" as a default interval, meaning the order limiting would reset at the top of every hour.
Since this change introduces sub-day resetting, I've also applied some updates to the messaging within WP Admin (e.g. "Based on your store's configuration, new orders have been put on hold until 4:00pm" instead of always defaulting to the date on which the next interval begins).
The customer-facing placeholders have also been updated, giving store owners the following options:
{current_interval}(e.g. "April 27, 2020"){current_interval:date}(alias of{current_interval}){current_interval:time}(e.g. "5:00pm"){next_interval}(e.g. "April 28, 2020"){next_interval:date}(alias of{next_interval}){next_interval:time}(e.g. "6:00pm"){limit}(e.g. "100")I've kept
{current_interval}and{next_interval}for backwards-compatibility purposes.Fixes #18.