Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{timezone} Placeholder #22

Closed
stevegrunwell opened this issue Apr 27, 2020 · 0 comments · Fixed by #26
Closed

{timezone} Placeholder #22

stevegrunwell opened this issue Apr 27, 2020 · 0 comments · Fixed by #26
Assignees
@stevegrunwell
Labels
enhancement New feature or request
Milestone
Version 1.2.0

Comments

@stevegrunwell
Copy link
Contributor

Since #18 is introducing intervals that last less than a day, timezones might come more into play. As such, it would be helpful to have a {timezone} placeholder for customer-facing messaging.
@stevegrunwell stevegrunwell added the enhancement New feature or request label Apr 27, 2020
@stevegrunwell stevegrunwell added this to the Version 1.2.0 milestone Apr 27, 2020
@stevegrunwell stevegrunwell self-assigned this Apr 27, 2020
stevegrunwell added a commit that referenced this issue Apr 27, 2020
@stevegrunwell
Add a new {timezone} placeholder
f6b3a92 
This commit adds a `{timezone}` placeholder, which works by calling `$next_interval_start->format('T')`, giving us the abbreviated version (e.g. "EST", "MDT", etc.) while also accounting for daylight saving time.

For future reference, we're using the *next* interval's start time as this placeholder is more likely to be used for when orders will be accepted again rather than when the current interval started. This avoids embarassing situations like "Please check back on $date at $time EST" when `$date` is in EDT.

Fixes #22.
@stevegrunwell stevegrunwell mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevegrunwell stevegrunwell

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.2.0
Development

Successfully merging a pull request may close this issue.

Add a new {timezone} placeholder nexcess/limit-orders
1 participant
@stevegrunwell