Minor optimization: List -> Queue (stablekernel#71)

* Minor optimization: List -> Queue * Fixing test.
newsvoice · Dec 17, 2018 · 8355255 · 8355255
1 parent 95ac5f9
commit 8355255
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/src/message_window.dart b/lib/src/message_window.dart
@@ -1,5 +1,7 @@
-import 'dart:typed_data';
+import 'dart:collection';
 import 'dart:io';
+import 'dart:typed_data';
+
 import 'server_messages.dart';
 
 class MessageFrame {
@@ -132,7 +134,7 @@ class MessageFrame {
 
 class MessageFramer {
   MessageFrame messageInProgress = new MessageFrame();
-  List<MessageFrame> messageQueue = [];
+  final messageQueue = new Queue<MessageFrame>();
 
   void addBytes(Uint8List bytes) {
     var offsetIntoBytesRead = 0;
@@ -151,6 +153,6 @@ class MessageFramer {
   bool get hasMessage => messageQueue.isNotEmpty;
 
   MessageFrame popMessage() {
-    return messageQueue.removeAt(0);
+    return messageQueue.removeFirst();
   }
 }
diff --git a/test/framer_test.dart b/test/framer_test.dart
@@ -223,7 +223,7 @@ List<int> bufferWithMessages(List<List<int>> messages) {
 }
 
 flush(MessageFramer framer) {
-  framer.messageQueue = [];
+  framer.messageQueue.clear();
   framer.addBytes(bufferWithMessages([
     messageWithBytes([1, 2, 3], 1)
   ]));