fix: Ads not loading - Enqueue window post messages until it's ready #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigbilner
reviewed
Sep 24, 2018
| } | ||
| }); | ||
| } | ||
|
|
||
| window.eventCallback = (type, detail) => { | ||
| // delay until next frame as React Native message bridge is not set up immediately |
There was a problem hiding this comment.
can remove the comment
craigbilner
reviewed
Sep 24, 2018
craigbilner
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.postMessage doesn't work until the webView is loaded. Our previous fix for this was to add a timeout to postMessages, but that's not 100% reliable. Implemented a separate approach where the window enqueues messages until post message is ready:
Based on: facebook/react-native#11594 (comment)