Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Node 20 #364

Merged
merged 6 commits into from
Nov 30, 2023
Merged

feat: Added support for Node 20 #364

merged 6 commits into from
Nov 30, 2023

Conversation

mrickard
Copy link
Member

@mrickard mrickard commented Jul 12, 2023

Added support for the newly-released Node 20 layers, including adding a specific test fixture showing layers for each Node version.
Updated semver to 7.5.4 (pulling from a stale update PR)

Closes #363
Closes NR-141651

@mrickard mrickard changed the title Added support for Node 20 feat: Added support for Node 20 Jul 12, 2023
@mrickard mrickard force-pushed the NR-141651/add-node-20 branch from ea8f2ab to b43a5a8 Compare July 14, 2023 16:45
@mrickard mrickard force-pushed the NR-141651/add-node-20 branch from b43a5a8 to 661306e Compare November 16, 2023 17:49
@mrickard mrickard closed this Nov 16, 2023
@mrickard mrickard reopened this Nov 16, 2023
@mrickard mrickard force-pushed the NR-141651/add-node-20 branch from 661306e to 3a3cd8e Compare November 16, 2023 17:54
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f7a26f) 33.08% compared to head (07264f3) 33.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   33.08%   33.08%           
=======================================
  Files           4        4           
  Lines         535      535           
  Branches      145      145           
=======================================
  Hits          177      177           
  Misses        330      330           
  Partials       28       28           
Flag Coverage Δ
unit-tests 33.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrickard mrickard marked this pull request as ready for review November 16, 2023 19:29
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add this to our list to fix? This feels very rigid to update post release

@mrickard
Copy link
Member Author

Can we also add this to our list to fix? This feels very rigid to update post release

Yes--I'll make a ticket for that.

@mrickard mrickard merged commit b0de90a into master Nov 30, 2023
3 checks passed
@bakeruk
Copy link

bakeruk commented Dec 4, 2023

Hi guys 👋🏼

This is great!

Will there be a tag and release for this merge?

@mrickard
Copy link
Member Author

mrickard commented Dec 4, 2023

@bakeruk We've just released v4.3.0, which includes support for Node 20. Thank you!

@mrickard mrickard deleted the NR-141651/add-node-20 branch March 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serverless plugin: Add support for Node 20
3 participants