-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cassandra): Env vars #999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkro
force-pushed
the
mro/NR-1789910/cassandra-env-vars
branch
6 times, most recently
from
November 29, 2023 22:21
611c9eb
to
a1faeb1
Compare
michaelkro
force-pushed
the
mro/NR-1789910/cassandra-env-vars
branch
2 times, most recently
from
December 11, 2023 18:22
a615da3
to
9d93e8d
Compare
NRhzhao
previously approved these changes
Dec 14, 2023
michaelkro
force-pushed
the
mro/NR-1789910/cassandra-env-vars
branch
from
December 15, 2023 00:07
30887fe
to
484f8d6
Compare
NRhzhao
approved these changes
Jan 2, 2024
NRhzhao
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Cassandra recipes to be able to accept required user input as environment variables. This is necessary so that we can add Cassandra as a target to
ansible-install
.Notes
Testing
Happy path
--localRecipes /path/to/recipes
Hostname
0.0.0.0
as an invalid value and running with--localRecipes
Custom port
JMX_PORT
incassandra-env.sh
and change it from7199
. Find the script on your host at:--localRecipes
and the CLI should prompt you for a portInstall in non-interactive mode with environment variables
-y
flag--debug
flag to see error outputLegacy environment variables