Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new config setup #976

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix new config setup #976

merged 2 commits into from
Sep 28, 2023

Conversation

alvarocabanas
Copy link
Contributor

Fix new config setup for super-agent release.
Logs-super-agent no longer has a dependency.

@NRhzhao
Copy link
Contributor

NRhzhao commented Sep 28, 2023

@alvarocabanas Looks like we can't just remove super-agent dependency from logs. This will cause the regular guided install to offer logs again (Super-agent logs).
Not sure why it wasn't working for you, but super-agent logs were installed when I tried earlier.
If you want to disable the super-agent log recipes for now, you can probably just do a exit 1 in the assert_pre_req step.
But, you would need to fix all the super-agent log tests, or they would all fail.

image

@alvarocabanas
Copy link
Contributor Author

@alvarocabanas Looks like we can't just remove super-agent dependency from logs. This will cause the regular guided install to offer logs again (Super-agent logs). Not sure why it wasn't working for you, but super-agent logs were installed when I tried earlier. If you want to disable the super-agent log recipes for now, you can probably just do a exit 1 in the assert_pre_req step. But, you would need to fix all the super-agent log tests, or they would all fail.

image

Sure, I have just rollbacked the logs modification and just left the super-agent ones.

@NRhzhao NRhzhao merged commit a223c19 into main Sep 28, 2023
@NRhzhao NRhzhao deleted the super_agent_update_config_last_release branch September 28, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants